Discussion:
[limesurvey-developers] First steps
Alfredo Esteban
2014-08-08 09:52:42 UTC
Permalink
Hi,

My name is Alfredo Esteban. I'm responsible for the Limesurvey instance of
a public Spanish organization. My user name in the bug tracker is aesteban.
You can verify I have reported some bugs (thanks for your quick response,
you are awesome).

As a legal requirement for every application in my organization we must log
every success login in the application. I would like to contribute to
Limesurvey by implementing it myself (creating a new table in database and
writing on it) and share with you. I tried to modify
*application/controllers/admin/authentication.php* but my changes didn't
take effect. I'm a beginner in PHP but I have good programming skills in C,
C++ and Java and LAMP administration.

So, could you please give me some guidelines about modifying and debug
Limesurvey (tools, tricks, etc)? Ideas and advices about this specific
change? Do you think this change make sense and could be included in
mainstream? Do you prefer to implement it yourself?

Any help is welcome,

Alfredo
Sam Mousa
2014-08-08 10:05:44 UTC
Permalink
Hi Esteban,

This functionality would be ideal for a plugin.

Try searching for PluginEvent in the source. In case you need a new event
(something like afterLogin) request it via the bugtracker.

Cheers,
Sam
Post by Alfredo Esteban
Hi,
My name is Alfredo Esteban. I'm responsible for the Limesurvey instance of
a public Spanish organization. My user name in the bug tracker is aesteban.
You can verify I have reported some bugs (thanks for your quick response,
you are awesome).
As a legal requirement for every application in my organization we must
log every success login in the application. I would like to contribute to
Limesurvey by implementing it myself (creating a new table in database and
writing on it) and share with you. I tried to modify
*application/controllers/admin/authentication.php* but my changes didn't
take effect. I'm a beginner in PHP but I have good programming skills in C,
C++ and Java and LAMP administration.
So, could you please give me some guidelines about modifying and debug
Limesurvey (tools, tricks, etc)? Ideas and advices about this specific
change? Do you think this change make sense and could be included in
mainstream? Do you prefer to implement it yourself?
Any help is welcome,
Alfredo
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
limesurvey-developers mailing list
https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
Marcel Minke
2014-08-08 10:07:03 UTC
Permalink
Hi Alfredo,

firstly please have a look at
http://manual.limesurvey.org/How_to_contribute_new_features. Your
requirement sound like something that may be very useful for others,
Carsten Schmitz
2014-08-08 10:11:03 UTC
Permalink
Hello Esteban

there is an existing plugin for this purpose which can be extended to
your needs. Is is called the 'Audit'-plugin and included in the
LimeSurvey package.
Please check it out.

Best regards from Hamburg/Germany

Carsten Schmitz

LimeSurvey Project Leader
***@limesurvey.org

http://www.limesurvey.org
Post by Alfredo Esteban
Hi,
My name is Alfredo Esteban. I'm responsible for the Limesurvey
instance of a public Spanish organization. My user name in the bug
tracker is aesteban. You can verify I have reported some bugs (thanks
for your quick response, you are awesome).
As a legal requirement for every application in my organization we
must log every success login in the application. I would like to
contribute to Limesurvey by implementing it myself (creating a new
table in database and writing on it) and share with you. I tried to
modify /application/controllers/admin/authentication.php/ but my
changes didn't take effect. I'm a beginner in PHP but I have good
programming skills in C, C++ and Java and LAMP administration.
So, could you please give me some guidelines about modifying and debug
Limesurvey (tools, tricks, etc)? Ideas and advices about this specific
change? Do you think this change make sense and could be included in
mainstream? Do you prefer to implement it yourself?
Any help is welcome,
Alfredo
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
limesurvey-developers mailing list
https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
---
Diese E-Mail ist frei von Viren und Malware, denn der avast! Antivirus Schutz ist aktiv.
http://www.avast.com
Marcel Minke
2014-08-08 11:38:05 UTC
Permalink
@Carsten, that being said can you please add a note at
https://www.limesurvey.org/en/forum/can-i-do-this-with-limesurvey/94941-audit-logging?q=/en/forum/can-i-do-this-with-limesurvey/94941-audit-logging?q=/en/forum/can-i-do-this-with-limesurvey/94941-audit-logging
and extend http://manual.limesurvey.org/Plugins so we have at least some
very basic documentation?!

@Alfredo: This may also be useful:
http://manual.limesurvey.org/Authentication_plugin_development#afterLoginFormSubmit

Best regards,
Marcel
Post by Carsten Schmitz
Hello Esteban
there is an existing plugin for this purpose which can be extended to
your needs. Is is called the 'Audit'-plugin and included in the
LimeSurvey package.
Please check it out.
Best regards from Hamburg/Germany
Carsten Schmitz
LimeSurvey Project Leader
http://www.limesurvey.org
Post by Alfredo Esteban
Hi,
My name is Alfredo Esteban. I'm responsible for the Limesurvey
instance of a public Spanish organization. My user name in the bug
tracker is aesteban. You can verify I have reported some bugs (thanks
for your quick response, you are awesome).
As a legal requirement for every application in my organization we
must log every success login in the application. I would like to
contribute to Limesurvey by implementing it myself (creating a new
table in database and writing on it) and share with you. I tried to
modify /application/controllers/admin/authentication.php/ but my
changes didn't take effect. I'm a beginner in PHP but I have good
programming skills in C, C++ and Java and LAMP administration.
So, could you please give me some guidelines about modifying and
debug Limesurvey (tools, tricks, etc)? Ideas and advices about this
specific change? Do you think this change make sense and could be
included in mainstream? Do you prefer to implement it yourself?
Any help is welcome,
Alfredo
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
limesurvey-developers mailing list
https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
------------------------------------------------------------------------
<http://www.avast.com/>
Diese E-Mail ist frei von Viren und Malware, denn der avast! Antivirus
<http://www.avast.com/> Schutz ist aktiv.
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
limesurvey-developers mailing list
https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
Alfredo Esteban
2014-08-12 10:02:34 UTC
Permalink
I enabled Audit plugin and I'm reading the code. I will try to write code
for login events (thanks a lot for your links, Marcel).

Thanks everybody!
Alfredo Esteban
2014-08-12 12:08:09 UTC
Permalink
Hi,

As I told you, I need log successful and unsuccessful login and logout of
users in admin site.

I'm looking for the right events in the list:

http://manual.limesurvey.org/Plugin_events

I think the event for logout is clear: beforeLogout.

However, beforeLogin is not what I'm looking for because it's called before
login form is showed. Either newUserSession because you have to provide a
user object, etc. These events are created to replace login method.

So, my question is: Does exist an event such as afterSuccessfulLogin and
afterFailLogin? Do you think it makes sense? Should I ask for it in bug
tracker?

Thanks in advance,

Alfredo
Post by Marcel Minke
@Carsten, that being said can you please add a note at
https://www.limesurvey.org/en/forum/can-i-do-this-with-limesurvey/94941-audit-logging?q=/en/forum/can-i-do-this-with-limesurvey/94941-audit-logging?q=/en/forum/can-i-do-this-with-limesurvey/94941-audit-logging
and extend http://manual.limesurvey.org/Plugins so we have at least some
very basic documentation?!
http://manual.limesurvey.org/Authentication_plugin_development#afterLoginFormSubmit
Best regards,
Marcel
Hello Esteban
there is an existing plugin for this purpose which can be extended to your
needs. Is is called the 'Audit'-plugin and included in the LimeSurvey
package.
Please check it out.
Best regards from Hamburg/Germany
Carsten Schmitz
LimeSurvey Project Leader
http://www.limesurvey.org
Hi,
My name is Alfredo Esteban. I'm responsible for the Limesurvey instance
of a public Spanish organization. My user name in the bug tracker is
aesteban. You can verify I have reported some bugs (thanks for your quick
response, you are awesome).
As a legal requirement for every application in my organization we must
log every success login in the application. I would like to contribute to
Limesurvey by implementing it myself (creating a new table in database and
writing on it) and share with you. I tried to modify
*application/controllers/admin/authentication.php* but my changes didn't
take effect. I'm a beginner in PHP but I have good programming skills in C,
C++ and Java and LAMP administration.
So, could you please give me some guidelines about modifying and debug
Limesurvey (tools, tricks, etc)? Ideas and advices about this specific
change? Do you think this change make sense and could be included in
mainstream? Do you prefer to implement it yourself?
Any help is welcome,
Alfredo
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.http://p.sf.net/sfu/bds
_______________________________________________
------------------------------
<http://www.avast.com/>
Diese E-Mail ist frei von Viren und Malware, denn der avast! Antivirus
<http://www.avast.com/> Schutz ist aktiv.
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.http://p.sf.net/sfu/bds
_______________________________________________
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
limesurvey-developers mailing list
https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
Denis Chenu
2014-08-17 16:28:35 UTC
Permalink
Hi,

I think you can use
http://manual.limesurvey.org/Authentication_plugin_development#afterLoginFormSubmit


But surely not the better system because i think you need a
afterLoginSucceed and an afterLoginFailure .

You can look for the place to put this plugin event and add it in LS
core with a pull request.

Denis
Post by Alfredo Esteban
Hi,
As I told you, I need log successful and unsuccessful login and logout
of users in admin site.
http://manual.limesurvey.org/Plugin_events
I think the event for logout is clear: beforeLogout.
However, beforeLogin is not what I'm looking for because it's called
before login form is showed. Either newUserSession because you have to
provide a user object, etc. These events are created to replace login
method.
So, my question is: Does exist an event such as afterSuccessfulLogin
and afterFailLogin? Do you think it makes sense? Should I ask for it
in bug tracker?
Thanks in advance,
Alfredo
@Carsten, that being said can you please add a note at
https://www.limesurvey.org/en/forum/can-i-do-this-with-limesurvey/94941-audit-logging?q=/en/forum/can-i-do-this-with-limesurvey/94941-audit-logging?q=/en/forum/can-i-do-this-with-limesurvey/94941-audit-logging
and extend http://manual.limesurvey.org/Plugins so we have at
least some very basic documentation?!
http://manual.limesurvey.org/Authentication_plugin_development#afterLoginFormSubmit
Best regards,
Marcel
Post by Carsten Schmitz
Hello Esteban
there is an existing plugin for this purpose which can be
extended to your needs. Is is called the 'Audit'-plugin and
included in the LimeSurvey package.
Please check it out.
Best regards from Hamburg/Germany
Carsten Schmitz
LimeSurvey Project Leader
http://www.limesurvey.org
Post by Alfredo Esteban
Hi,
My name is Alfredo Esteban. I'm responsible for the Limesurvey
instance of a public Spanish organization. My user name in the
bug tracker is aesteban. You can verify I have reported some
bugs (thanks for your quick response, you are awesome).
As a legal requirement for every application in my organization
we must log every success login in the application. I would like
to contribute to Limesurvey by implementing it myself (creating
a new table in database and writing on it) and share with you. I
tried to modify
/application/controllers/admin/authentication.php/ but my
changes didn't take effect. I'm a beginner in PHP but I have
good programming skills in C, C++ and Java and LAMP administration.
So, could you please give me some guidelines about modifying and
debug Limesurvey (tools, tricks, etc)? Ideas and advices about
this specific change? Do you think this change make sense and
could be included in mainstream? Do you prefer to implement it
yourself?
Any help is welcome,
Alfredo
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
limesurvey-developers mailing list
https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
------------------------------------------------------------------------
<http://www.avast.com/>
Diese E-Mail ist frei von Viren und Malware, denn der avast!
Antivirus <http://www.avast.com/> Schutz ist aktiv.
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
limesurvey-developers mailing list
https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
limesurvey-developers mailing list
https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
------------------------------------------------------------------------------
_______________________________________________
limesurvey-developers mailing list
https://lists.sourceforge.net/lists/listinfo/limesurvey-developers
Loading...